feat(objects): cnx 931 create archicadobject #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removes unused gis classes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #200 +/- ##
===========================================
+ Coverage 57.62% 69.43% +11.81%
===========================================
Files 249 266 +17
Lines 9969 10687 +718
Branches 1084 1085 +1
===========================================
+ Hits 5745 7421 +1676
+ Misses 3969 2919 -1050
- Partials 255 347 +92 ☔ View full report in Codecov by Sentry. |
oguzhankoral
previously approved these changes
Jan 14, 2025
oguzhankoral
approved these changes
Jan 22, 2025
clairekuang
deleted the
claire/cnx-931-create-archicadobject-in-speckle-sharp-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ArchicadObject : DataObjectclass and its corresponding interface to allow for precise deserialization in speckle sharp.Also removes unused arcgis classes and interface.
Wait to merge: